Nuke: double slate #3521
Nuke: double slate #3521
Conversation
|
Task linked: OP-3520 Sort nodes by name |
| "-codec:v", | ||
| "-pixfmt", |
There was a problem hiding this comment.
Args for codec and pixfmt should be filled same way as here https://github.com/pypeclub/OpenPype/pull/3521/files#diff-1064edbd703275fe1bdff4855b452f266ceef997f708712a16a9a21740653a68R186
There was a problem hiding this comment.
is the link working?
There was a problem hiding this comment.
Args for codec and pixfmt are actually not needed. The bitrate is.
There was a problem hiding this comment.
is the link working?
Seems like it's not. There is format_args and codec_args calculated from source (approximately line 186). That must be used as source for codec and pixfmt instead.
They actually must be filled otherwise ffmpeg will use default values for the codec and format.
The same applies for format. For example if mxf OPAtom would be processed without that arguments output won't be OPAtom but default mxf profile defined by ffmpeg.
|
here is the two versions from my tests and both of them are the same. |
|
closing #3520 |
Brief description
This changes a way to merge slate with review. Now it reencodes, so all apps can read the result with slate correctly.
Also, reviews with audio and slate now have audio again.
I tested on op-atom MXF, DNxHD mov, Prores mov, H264 in mp4. With audio (except MXF) and with two ExtractReviewDataMov Output Definitions. Local publish, clean working folder.
Testing notes: